mozilla-xp.com | Post Question | Search | About | Groups | Contact | Register | Login



mozilla feedback firefox (6175)

mozilla feedback (2077)

mozilla feedback firefox prerelease (1989)

mozilla feedback companion ebay (1632)

mozilla feedback thunderbird (857)

mozilla support thunderbird (796)

mozilla support seamonkey (507)

mozilla dev tech crypto checkins (460)

mozilla support firefox (402)

mozilla support bugzilla (395)

mozilla dev extensions (358)

mozilla feedback thunderbird prerelease (334)

netscape public mozilla reviewers (272)

mozilla dev mdc feedback (270)

netscape public beta feedback (268)

netscape public mozilla crypto checkins (265)

mozilla dev apps thunderbird (251)

netscape public mozilla jobs (224)

mozilla dev tech plugins (194)

mozilla dev apps firefox (189)

mozilla dev tech xul (189)

mozilla dev apps calendar (187)

mozilla dev embedding (181)

netscape public mozilla embedding (177)

netscape public mozilla test (174)

netscape public dev xul (169)

mozilla dev planning (168)

mozilla support calendar (167)

mozilla dev tech js-engine rhino (164)

mozilla test (163)

netscape public mozilla jseng (160)

netscape public mozilla crash-data (159)

netscape public mozilla xpcom (159)

netscape public mozilla layout xslt (158)

mozilla dev platform (157)

mozilla dev platforms mobile (157)

mozilla marketing (155)

mozilla jobs (153)

mozilla dev builds (152)

mozilla dev tech xpcom (150)

netscape public mozilla webtools (149)

mozilla dev accessibility (147)

mozilla support webtools (147)

netscape public mozilla calendar (139)

netscape public mozilla gtk (136)

mozilla dev tech java (135)

mozilla community drumbeat (134)

netscape public mozilla xml (132)

mozilla dev tree-management (131)

mozilla dev apps bugzilla (130)

netscape public mozilla i18n (130)

netscape public mozilla prefs (129)

netscape public mozilla qa general (129)

mozilla dev amo (128)

netscape public mozilla rdf (126)

netscape public mozilla xpinstall (126)

netscape public mozilla xpfe (123)

netscape public mozilla plugins (122)

netscape public mozilla java (122)

netscape public mozilla general (120)

netscape public mozilla ui (119)

netscape public mozilla accessibility (118)

netscape public mozilla wishlist (117)

netscape public mozilla mac (116)

mozilla dev tech js-engine (116)

mozilla dev apps seamonkey (116)

netscape public mozilla mathml (112)

netscape public mozilla crypto (112)

netscape public mozilla beos (111)

netscape public mozilla jsdebugger (110)

netscape public mozilla license (109)

mozilla dev tech crypto (109)

netscape public mozilla qa browser (109)

mozilla wishlist (108)

mozilla dev tech xforms (106)

netscape public mozilla directory (106)

netscape public mozilla editor (106)

mozilla dev quality (106)

netscape public mozilla macosx (106)

mozilla dev apps js-debugger (105)

netscape public mozilla performance (103)

netscape public mozilla builds (100)

mozilla dev ports os2 (100)

netscape public mozilla qt (98)

netscape public mozilla mail-news (97)

mozilla announce (96)

netscape public mozilla documentation (94)

netscape public mozilla os2 (93)

netscape public mozilla nspr (93)

netscape public mozilla netlib (93)

netscape public mozilla style (92)

mozilla support planning (92)

netscape public mozilla patches (91)

mozilla dev l10n web (91)

mozilla dev tech nspr (89)

mozilla dev mdc (87)

mozilla dev tech network (87)

mozilla dev tech css (86)

mozilla dev l10n (85)

mozilla dev l10n cs (85)


netscape.public.mozilla.reviewers Post New
Items(272) /3 Next >> Last >|
Subject Posted Replies From
HTML Correction in Mozilla

Hello All, Could any one give me short description on how HTML errors like unclosed tags are corrected in Firefox? Thanks in advance Chanchal

10/15/2009 1:44:46 PM 0 Chanchal <chanchal.ja...@gmail.com>



(IVAN): OUR GOD WHO HAS CALLED YOU IS ETERNALLY FAITHFUL TO YOU

S�bado, 19 de julio, a�o 2008 de Nuestro Salvador Jesucristo, Guayaquil, Ecuador - Iberoam�rica (Felices Fiestas Julianas de Guayaquil 2008 a todas nuestras familias dentro y fuera de nuestras tierras. Muchas felicidades a todos y que se gocen en estos d�as festivos con el Se�or Jesucristo y con las bendiciones abundantes de su Esp�ritu Santo, delante de nuestro Padre Celestial y de sus �ngeles fieles. �Feliz d�a de la Independencia a toda Colombia y al resto de nuestras naciones Iberoamericanas 2008!) (Cartas del cielo son escritas por Iv�n Valarezo) OUR GOD

7/22/2008 9:48:31 PM 0 ELIO IVAN VALAREZO <valar...@netzero.com>
Pam in netscape.public.mozilla.reviewers

Law enforcement is now intercepting text messages, as proven by Operation Sudden Fall in San Diego. http://www.usdoj.gov/dea/pubs/states/newsrel/sd050608.html http://www.signonsandiego.com/news/education/20080506-1338-bn06sdsu2.html Don't let your personal SMS/text messages fall into the wrong hands. Encrypt your messages with one of these: http://www.Xecure.net http://www.CryptoSMS.org http://www.CryptoSMS.com http://www.KrypText.co.uk http://www.CryptoGraf.com http://www.Cop2p.com/encrypted_sms.html http://www.FortressMail.net/fortress_sms.htm htt

5/24/2008 4:22:32 AM 0 Yani.H...@booklet.nj.us
Fatloss computer program

I have been using this computer program for a couple weeks now and i am very pleased with the results so far. its a software fatloss program, if your looking for a diet/weightloss plan i reccomend you check this place out first: http://fatloss9.50webs.com

10/15/2007 11:40:15 PM 0 Angel vasquez<vange...@yahoo.com>
HP Desktop for sale!

Hi, I have an unused HP Pavilion with the fallowing specs: # Processor: AMD Athlon 64 X2 4000+ (2.1GHz, 2000MT/s System Bus) # Memory: 2048MB PC2-5300 DDR2 SDRAM memory (2x1GB) (expandable to 8 GB (4 x 2 GB) (64-bit OS)/ 4 GB (4 x 1 GB) (32-bit OS)) # Hard Drive:320GB 7200RPM SATA 3G (3.0 Gb/sec) hard drive # Optical Drive: 16X DVD(+/-)R/RW 12X RAM (+/-)R DL LightScribe SATA drive # Expandable Drive Bay: HP Pocket Media Drive bay # Video Graphics: Integrated graphics # Network Interface: Integrated 10/100BaseT network interface # Sound: High Definition 8-channel audio # Fax/Modem:

10/14/2007 8:18:39 AM 0 pbdude<pbdude...@yahoo.com>
Watch NFL Games Online

Watch NFL Games Online! For every one who wants to watch the games online because they dont live in the teams town or are at work i found a site that has basically every game covered. Its perfect if you have afford a monthly $70 direct tv nfl access subscription. they got a bunch of channels The sites http://nflonline.wizhoo.com

10/14/2007 2:08:34 AM 0 Dexter H.<dexterhussain...@yahoo.com>
Super-review request for patch for bug 346035

Could it possible to get super-review for patch for bug report? https://bugzilla.mozilla.org/show_bug.cgi?id=364035 Who could be possible super-reviewer? Short summary: patch modifies spell-check manager to add a possibility of external spell-check engines from Mozilla programs. When patch is applied, extension may register external spell-check engine using nsICategoryManager interface (one category reserved for this purpose). Tested with using both HunSpell and 1 external spell-checker from extension on Linux x86 and x86_64. Some tests done also for WIN32 (unfortunate

9/10/2007 4:52:12 AM 0 Andris Pavenis <andris.pave...@iki.fi>
how can I post http parameters into internet explorer.

I need to hack an http post for testing purposes. Page one.asp has a seried of dropdowns for criteria. Page two.asp lists results based on the criteria selected in page one. The pages use form post to pass parameters between themselves. No querystring params. Is there any way I can make a custom http message that posts directly to page two.asp and renders in IE? I've been using fiddler to monitor the http between the 2 pages but I don't know how to take what's createrd in fiddler and post it to internet explorer. Any help would be appreciated. Thanks Eric

4/9/2007 11:31:53 PM 0 ericlangl...@msn.com
Incontri Nuovi Amici, Scambisti & Compagni SESSUALI!

Incontri Nuovi Amici, Scambisti & Compagni SESSUALI! http://www.centrobanner.com

6/27/2006 12:50:06 PM 0 "valentina" <valent...@microsoft.com>
We are all knots with a lot wants of sex

We are all knots with a lot wants of sex http://www.centrobanner.com

6/24/2006 3:51:26 PM 0 "angela" <ang...@msn.com>
[ADMIN] This list is now closed!

If all goes according to plan, this should be the last post you receive on the mailing list version of this group. All subscribers to the mailing list should shortly receive a subscription notice for dev-super-review@lists.mozilla.org. If you are reading this via the netscape.public.mozilla.reviewers newsgroup, this newsgroup is now considered officially abandoned. We have moved to mozilla.dev.super-review, which is available via the news.mozilla.org news server. -- Dave Miller System Administrator, Mozilla Corporation http://www.mozilla.com/

1/23/2006 8:05:57 AM 0 Dave Miller <justd...@mozilla.com>
superreview requested: [Bug 323842] Add "Allow for session" option in cookie acceptance sheet : [Attachment 208836] Fixes capitalisation, cleans up logic per Stuart's comments on IRC

Stuart Morgan <stuart.morgan@alumni.case.edu> has asked for superreview: Bug 323842: Add "Allow for session" option in cookie acceptance sheet https://bugzilla.mozilla.org/show_bug.cgi?id=323842 Attachment 208836: Fixes capitalisation, cleans up logic per Stuart's comments on IRC https://bugzilla.mozilla.org/attachment.cgi?id=208836&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> r=me. Works as advertized. This shouldn't be checked in without the patch for bug 302865, or the policy-editing table will be wrong. Also needs "Allow for

1/23/2006 7:55:59 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 302865] In cookies exceptions list, should also have option for session cookies only, not just allow/deny : [Attachment 209319] fixed per stuart's comments, also fixes bro

Stuart Morgan <stuart.morgan@alumni.case.edu> has asked for superreview: Bug 302865: In cookies exceptions list, should also have option for session cookies only, not just allow/deny https://bugzilla.mozilla.org/show_bug.cgi?id=302865 Attachment 209319: fixed per stuart's comments, also fixes broken search on policy column https://bugzilla.mozilla.org/attachment.cgi?id=209319&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Looks good--and yes pink, I even tested aol.com ;) r=me

1/23/2006 7:27:17 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324378] Attribute setting isn't always "first wins" : [Attachment 209333] Fix

Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 324378: Attribute setting isn't always "first wins" https://bugzilla.mozilla.org/show_bug.cgi?id=324378 Attachment 209333: Fix https://bugzilla.mozilla.org/attachment.cgi?id=209333&action=edit

1/23/2006 6:54:03 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324377] cloneNode(file input) between documents loses value on submit() : [Attachment 209331] Patch

Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 324377: cloneNode(file input) between documents loses value on submit() https://bugzilla.mozilla.org/show_bug.cgi?id=324377 Attachment 209331: Patch https://bugzilla.mozilla.org/attachment.cgi?id=209331&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> So the actual issue here (based on debugging Arpad's testcase) is that we're submitting before initial reflow of the file control frame, and that can't get the value off the mTextFrame until it s

1/23/2006 6:29:50 AM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 323853] JB_BP not exported by newer glibc (2.4) : [Attachment 208878] patch (complete)

Mike Shaver <shaver@mozilla.org> has granted Mike Shaver <shaver@mozilla.org>'s request for superreview: Bug 323853: JB_BP not exported by newer glibc (2.4) https://bugzilla.mozilla.org/show_bug.cgi?id=323853 Attachment 208878: patch (complete) https://bugzilla.mozilla.org/attachment.cgi?id=208878&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> Ah, OK. So people on those platforms will get a "write me, dammit" output when they crash, rather than a stack. I can live with that, though it's likely to be a little confusing (and make people wonder at fir

1/23/2006 6:28:05 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 208871] Does not surf to history list item I clicked : [Attachment 205534] the right patch

Andrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 208871: Does not surf to history list item I clicked https://bugzilla.mozilla.org/show_bug.cgi?id=208871 Attachment 205534: the right patch https://bugzilla.mozilla.org/attachment.cgi?id=205534&action=edit

1/23/2006 4:24:11 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 323806] Fix for bug 175893 breaks tab switching if content is not HTML : [Attachment 209323] just try/catch

Andrew Schultz <ajschult@verizon.net> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 323806: Fix for bug 175893 breaks tab switching if content is not HTML https://bugzilla.mozilla.org/show_bug.cgi?id=323806 Attachment 209323: just try/catch https://bugzilla.mozilla.org/attachment.cgi?id=209323&action=edit ------- Additional Comments from Andrew Schultz <ajschult@verizon.net> This should restore pre-175893 behavior. It fixes the testcase for this bug and shouldn't break anything. At this point, I'm more concerned with unbreaking the br

1/23/2006 3:38:33 AM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 321490] Make SeaMonkey compatible again with moveTabTo implementation of the Firefox : [Attachment 209313] Option (b) with >=

jag (Peter Annema) <jag@tty.nl> has cancelled jag (Peter Annema) <jag@tty.nl>'s request for superreview: Bug 321490: Make SeaMonkey compatible again with moveTabTo implementation of the Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=321490 Attachment 209313: Option (b) with >= https://bugzilla.mozilla.org/attachment.cgi?id=209313&action=edit

1/23/2006 3:32:24 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 321490] Make SeaMonkey compatible again with moveTabTo implementation of the Firefox : [Attachment 209313] Option (b) with >=

jag (Peter Annema) <jag@tty.nl> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 321490: Make SeaMonkey compatible again with moveTabTo implementation of the Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=321490 Attachment 209313: Option (b) with >= https://bugzilla.mozilla.org/attachment.cgi?id=209313&action=edit ------- Additional Comments from jag (Peter Annema) <jag@tty.nl> I was ready to check in when I realized that by grabbing |tab| from insertBefore we lose any additional properties set on the tab passed in. So, for full comp

1/23/2006 1:00:34 AM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 322592] Software Update Menu Item : [Attachment 208909] Patch v4

Stuart Morgan <stuart.morgan@alumni.case.edu> has cancelled H�kan Waara <hwaara@gmail.com>'s request for superreview: Bug 322592: Software Update Menu Item https://bugzilla.mozilla.org/show_bug.cgi?id=322592 Attachment 208909: Patch v4 https://bugzilla.mozilla.org/attachment.cgi?id=208909&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> (r-'ing based on my comment 48 (including need for app.update.url.override support))

1/23/2006 12:50:09 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 308019] ###!!! ASSERTION: Computed overflow area must contain frame bounds: 'aNewSize.width == 0 || aNewSize.height == 0 || aOverflowArea->Contains(nsRect(nsPoint(0, 0), aN

Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 308019: ###!!! ASSERTION: Computed overflow area must contain frame bounds: 'aNewSize.width == 0 || aNewSize.height == 0 || aOverflowArea->Contains(nsRect(nsPoint(0, 0), aNewSize))', file nsFrame.cpp, line 4301 https://bugzilla.mozilla.org/show_bug.cgi?id=308019 Attachment 209312: I think this is the right fix... https://bugzilla.mozilla.org/attachment.cgi?id=209312&action=edit

1/23/2006 12:40:35 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 308182] Iframes are not drawn after being shown : [Attachment 209311] Patch to fix

Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 308182: Iframes are not drawn after being shown https://bugzilla.mozilla.org/show_bug.cgi?id=308182 Attachment 209311: Patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=209311&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This has been broken since about forever, actually... The problem is that we destroy the frame but don't null out the parentWidget on the docshell. Then when the document starts to load we create a presentation (see Docum

1/23/2006 12:28:35 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324285] Improve nsISHistoryListener.idl documentation : [Attachment 209231] patch

Nickolay Ponomarev <asqueella@gmail.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 324285: Improve nsISHistoryListener.idl documentation https://bugzilla.mozilla.org/show_bug.cgi?id=324285 Attachment 209231: patch https://bugzilla.mozilla.org/attachment.cgi?id=209231&action=edit

1/22/2006 11:39:28 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 303039] ASSERTION: max-width didn't include padding?: 'kidContentMaxWidth >= 0' : [Attachment 209307] Proposed fix

Boris Zbarsky <bzbarsky@mit.edu> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 303039: ASSERTION: max-width didn't include padding?: 'kidContentMaxWidth >= 0' https://bugzilla.mozilla.org/show_bug.cgi?id=303039 Attachment 209307: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=209307&action=edit

1/22/2006 10:32:45 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 321040] observer service should remove null weak references from observer lists when enumerating : [Attachment 209305] document the nsIWeakReference contract better

David Baron <dbaron@mozilla.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 321040: observer service should remove null weak references from observer lists when enumerating https://bugzilla.mozilla.org/show_bug.cgi?id=321040 Attachment 209305: document the nsIWeakReference contract better https://bugzilla.mozilla.org/attachment.cgi?id=209305&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.com> This attempts to document what I believe is the contract provided by the nsIWeakReference / nsISupportsWeakReference interfaces.

1/22/2006 10:16:44 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 211999] Can't redirect to data: urls : [Attachment 209302] Patch to fix

Boris Zbarsky <bzbarsky@mit.edu> has asked Darin Fisher <darin@meer.net> for superreview: Bug 211999: Can't redirect to data: urls https://bugzilla.mozilla.org/show_bug.cgi?id=211999 Attachment 209302: Patch to fix https://bugzilla.mozilla.org/attachment.cgi?id=209302&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> I've verified (by stepping through the process in a debugger, though this is also possible to verify via code inspection) that the new document gets a principal based on the data: URI. This means that it will be same-origin with any other

1/22/2006 10:05:11 PM 0 bugzilla-request-dae...@mozilla.org
superreview denied: [Bug 323853] JB_BP not exported by newer glibc (2.4) : [Attachment 208878] patch (complete)

Mike Shaver <shaver@mozilla.org> has denied Wolfgang Rosenauer <mozilla@rosenauer.org>'s request for superreview: Bug 323853: JB_BP not exported by newer glibc (2.4) https://bugzilla.mozilla.org/show_bug.cgi?id=323853 Attachment 208878: patch (complete) https://bugzilla.mozilla.org/attachment.cgi?id=208878&action=edit ------- Additional Comments from Mike Shaver <shaver@mozilla.org> > static char _progname[1024] = "huh?"; > >-#if defined(LINUX) && defined(DEBUG) && (defined(__i386) || defined(PPC)) >+#if defined(LINUX) && defined(DEBUG) > #define CRAWL_STACK_ON_SIGSEGV > #endi

1/22/2006 7:44:55 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 323853] JB_BP not exported by newer glibc (2.4) : [Attachment 208878] patch (complete)

Wolfgang Rosenauer <mozilla@rosenauer.org> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 323853: JB_BP not exported by newer glibc (2.4) https://bugzilla.mozilla.org/show_bug.cgi?id=323853 Attachment 208878: patch (complete) https://bugzilla.mozilla.org/attachment.cgi?id=208878&action=edit

1/22/2006 7:10:16 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 305028] Get Cairo working on OS/2 : [Attachment 209286] Updated patch

Peter Weilbacher <mozilla@Weilbacher.org> has asked Michael Kaply (IBM) (mkaply) <mozilla@kaply.com> for superreview: Bug 305028: Get Cairo working on OS/2 https://bugzilla.mozilla.org/show_bug.cgi?id=305028 Attachment 209286: Updated patch https://bugzilla.mozilla.org/attachment.cgi?id=209286&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> Updated my last cairo patch for OS/2 to - contain no cairo stuff directly any more (I hope that we will get the stuff in gfx/cairo/cairo/src into CVS on the cairo route) - not mess with the Makefile.ins t

1/22/2006 7:09:48 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 88569] Change Online/Offline icons to make state obvious : [Attachment 177325] Online-Icon

Peter Weilbacher <mozilla@Weilbacher.org> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 88569: Change Online/Offline icons to make state obvious https://bugzilla.mozilla.org/show_bug.cgi?id=88569 Attachment 177325: Online-Icon for skin/classic/communicator/icons/online.gif https://bugzilla.mozilla.org/attachment.cgi?id=177325&action=edit

1/22/2006 12:01:34 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 88569] Change Online/Offline icons to make state obvious : [Attachment 177323] Offline- Icon

Peter Weilbacher <mozilla@Weilbacher.org> has asked jag (Peter Annema) <jag@tty.nl> for superreview: Bug 88569: Change Online/Offline icons to make state obvious https://bugzilla.mozilla.org/show_bug.cgi?id=88569 Attachment 177323: Offline- Icon for skin/classic/communicator/icons/offline.gif https://bugzilla.mozilla.org/attachment.cgi?id=177323&action=edit ------- Additional Comments from Peter Weilbacher <mozilla@Weilbacher.org> Perhaps iann has more time to look at stuff like this.

1/22/2006 12:01:08 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 321490] Make SeaMonkey compatible again with moveTabTo implementation of the Firefox : [Attachment 209046] Use mTabs.item() and get tab from insertBefore

neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has granted neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com>'s request for superreview: Bug 321490: Make SeaMonkey compatible again with moveTabTo implementation of the Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=321490 Attachment 209046: Use mTabs.item() and get tab from insertBefore https://bugzilla.mozilla.org/attachment.cgi?id=209046&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> OK, sr=me with >= as noted.

1/22/2006 10:27:05 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 323472] Crash when Places imports FF1.5 bookmarks : [Attachment 209262] patch

Brian Ryner <bryner@brianryner.com> has asked Darin Fisher <darin@meer.net> for superreview: Bug 323472: Crash when Places imports FF1.5 bookmarks https://bugzilla.mozilla.org/show_bug.cgi?id=323472 Attachment 209262: patch https://bugzilla.mozilla.org/attachment.cgi?id=209262&action=edit ------- Additional Comments from Brian Ryner <bryner@brianryner.com> The first part of this patch is pretty straightforward. I changed the LivemarkInfo objects to be heap-allocated so we don't have to worry about them moving. I noticed another problem though -- it seems like we need to clean

1/22/2006 9:00:50 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 258006] Mouse-wheel scroll events does not propagate to viewport from fixed pos. elements : [Attachment 209254] Patch rv1.1

Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 258006: Mouse-wheel scroll events does not propagate to viewport from fixed pos. elements https://bugzilla.mozilla.org/show_bug.cgi?id=258006 Attachment 209254: Patch rv1.1 https://bugzilla.mozilla.org/attachment.cgi?id=209254&action=edit

1/22/2006 4:13:29 AM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 258006] Mouse-wheel scroll events does not propagate to viewport from fixed pos. elements : [Attachment 209211] Patch rv1.0

Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has cancelled Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com>'s request for superreview: Bug 258006: Mouse-wheel scroll events does not propagate to viewport from fixed pos. elements https://bugzilla.mozilla.org/show_bug.cgi?id=258006 Attachment 209211: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=209211&action=edit

1/22/2006 4:13:28 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 323781] Prints still go to printer even after it is deleted : [Attachment 209247] Revised patch v0.2

Ian Neal <iann_bugzilla@arlen.demon.co.uk> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 323781: Prints still go to printer even after it is deleted https://bugzilla.mozilla.org/show_bug.cgi?id=323781 Attachment 209247: Revised patch v0.2 https://bugzilla.mozilla.org/attachment.cgi?id=209247&action=edit ------- Additional Comments from Ian Neal <iann_bugzilla@arlen.demon.co.uk> Changes since v0.1: * Created IsPrinterAvailable static help function and other tidy ups as per comment 6. * Changed GetAdjustedPrinterName to only be called when aUsePNP is

1/22/2006 1:48:33 AM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 323781] Prints still go to printer even after it is deleted : [Attachment 209154] Provisional patch v0.1

Ian Neal <iann_bugzilla@arlen.demon.co.uk> has cancelled Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 323781: Prints still go to printer even after it is deleted https://bugzilla.mozilla.org/show_bug.cgi?id=323781 Attachment 209154: Provisional patch v0.1 https://bugzilla.mozilla.org/attachment.cgi?id=209154&action=edit

1/22/2006 1:31:05 AM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 320688] copyright notice for SupportSoft but no Talkback in the SeaMonkey 1.0 builds : [Attachment 209198] patch, for 1.8.0.x only

neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has granted Chris Thomas (CTho) <cst@andrew.cmu.edu>'s request for superreview: Bug 320688: copyright notice for SupportSoft but no Talkback in the SeaMonkey 1.0 builds https://bugzilla.mozilla.org/show_bug.cgi?id=320688 Attachment 209198: patch, for 1.8.0.x only https://bugzilla.mozilla.org/attachment.cgi?id=209198&action=edit

1/22/2006 12:31:16 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 321932] Breakpoints do not show up in Source Code view : [Attachment 209232] part I: Fix venkman

Christian Biesinger (:bi) (reviews slower than usual) <cbiesinger@gmx.at> has asked Darin Fisher <darin@meer.net> for superreview: Bug 321932: Breakpoints do not show up in Source Code view https://bugzilla.mozilla.org/show_bug.cgi?id=321932 Attachment 209232: part I: Fix venkman https://bugzilla.mozilla.org/attachment.cgi?id=209232&action=edit ------- Additional Comments from Christian Biesinger (:bi) (reviews slower than usual) <cbiesinger@gmx.at> ok, thanks. Here, then, is part 1 of the patch, which fixes the venkman channel impl. I'll attach a part 2 later, which will make

1/21/2006 10:48:40 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 323382] Saving any page gives ASSERTION: Did you know you were calling |do_GetInterface()| on an object that doesn't support the |nsIInterfaceRequestor| interface? : [Attach

Boris Zbarsky <bzbarsky@mit.edu> has granted Martijn Wargers <martijn.martijn@gmail.com>'s request for superreview: Bug 323382: Saving any page gives ASSERTION: Did you know you were calling |do_GetInterface()| on an object that doesn't support the |nsIInterfaceRequestor| interface? https://bugzilla.mozilla.org/show_bug.cgi?id=323382 Attachment 209008: assertion killer https://bugzilla.mozilla.org/attachment.cgi?id=209008&action=edit

1/21/2006 10:20:46 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 323382] Saving any page gives ASSERTION: Did you know you were calling |do_GetInterface()| on an object that doesn't support the |nsIInterfaceRequestor| interface? : [Atta

Martijn Wargers <martijn.martijn@gmail.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 323382: Saving any page gives ASSERTION: Did you know you were calling |do_GetInterface()| on an object that doesn't support the |nsIInterfaceRequestor| interface? https://bugzilla.mozilla.org/show_bug.cgi?id=323382 Attachment 209008: assertion killer https://bugzilla.mozilla.org/attachment.cgi?id=209008&action=edit

1/21/2006 9:17:21 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 243159] TableProcessChild makes some bogus assumptions : [Attachment 209222] �No Pasar�n!

Bernd <bernd_mozilla@gmx.de> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 243159: TableProcessChild makes some bogus assumptions https://bugzilla.mozilla.org/show_bug.cgi?id=243159 Attachment 209222: �No Pasar�n! https://bugzilla.mozilla.org/attachment.cgi?id=209222&action=edit

1/21/2006 9:08:36 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 306900] nsDocument::StartDocumentLoad must not leave aDocListener untouched : [Attachment 209212] Do the virtual thing

Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 306900: nsDocument::StartDocumentLoad must not leave aDocListener untouched https://bugzilla.mozilla.org/show_bug.cgi?id=306900 Attachment 209212: Do the virtual thing https://bugzilla.mozilla.org/attachment.cgi?id=209212&action=edit

1/21/2006 6:13:52 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 258006] Mouse-wheel scroll events does not propagate to viewport from fixed pos. elements : [Attachment 209211] Patch rv1.0

Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 258006: Mouse-wheel scroll events does not propagate to viewport from fixed pos. elements https://bugzilla.mozilla.org/show_bug.cgi?id=258006 Attachment 209211: Patch rv1.0 https://bugzilla.mozilla.org/attachment.cgi?id=209211&action=edit ------- Additional Comments from Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> On current code, the most ancestor frame of inner fixed positioned frame is not document root frame. Therefore,

1/21/2006 5:13:54 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 302911] crash when attempting to print the page [@ nsCachedStyleData::GetStyleData] : [Attachment 209201] patch

Bernd <bernd_mozilla@gmx.de> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 302911: crash when attempting to print the page [@ nsCachedStyleData::GetStyleData] https://bugzilla.mozilla.org/show_bug.cgi?id=302911 Attachment 209201: patch https://bugzilla.mozilla.org/attachment.cgi?id=209201&action=edit ------- Additional Comments from Bernd <bernd_mozilla@gmx.de> Do exactly what Chris told to do allready in 2001...

1/21/2006 2:39:21 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 320688] copyright notice for SupportSoft but no Talkback in the SeaMonkey 1.0 builds : [Attachment 209198] patch, for 1.8.0.x only

Chris Thomas (CTho) <cst@andrew.cmu.edu> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 320688: copyright notice for SupportSoft but no Talkback in the SeaMonkey 1.0 builds https://bugzilla.mozilla.org/show_bug.cgi?id=320688 Attachment 209198: patch, for 1.8.0.x only https://bugzilla.mozilla.org/attachment.cgi?id=209198&action=edit

1/21/2006 2:25:43 PM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 51767] [HLP][HBTN]HTMLButtonControlFrame should process its children more efficiently : [Attachment 207986] rev. patch

Bernd <bernd_mozilla@gmx.de> has cancelled Bernd <bernd_mozilla@gmx.de>'s request for superreview: Bug 51767: [HLP][HBTN]HTMLButtonControlFrame should process its children more efficiently https://bugzilla.mozilla.org/show_bug.cgi?id=51767 Attachment 207986: rev. patch https://bugzilla.mozilla.org/attachment.cgi?id=207986&action=edit

1/21/2006 1:15:34 PM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 51767] [HLP][HBTN]HTMLButtonControlFrame should process its children more efficiently : [Attachment 205074] revised patch

Bernd <bernd_mozilla@gmx.de> has cancelled Bernd <bernd_mozilla@gmx.de>'s request for superreview: Bug 51767: [HLP][HBTN]HTMLButtonControlFrame should process its children more efficiently https://bugzilla.mozilla.org/show_bug.cgi?id=51767 Attachment 205074: revised patch https://bugzilla.mozilla.org/attachment.cgi?id=205074&action=edit

1/21/2006 1:15:02 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 296159] npruntime API does not support enumeration : [Attachment 209192] &#65328;atch v7

Alfred Peng <alfred.peng@sun.com> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 296159: npruntime API does not support enumeration https://bugzilla.mozilla.org/show_bug.cgi?id=296159 Attachment 209192: &#65328;atch v7 https://bugzilla.mozilla.org/attachment.cgi?id=209192&action=edit ------- Additional Comments from Alfred Peng <alfred.peng@sun.com> To compare with patch v6, this patch add the "ThrowJSException" function call to three error return places.

1/21/2006 9:30:49 AM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 312062] Crash closing a window with a plugin [@ nsObjectFrame::NotifyContentObjectWrapper] : [Attachment 209181] Attachment 206646 from bug 136927 modified to avoid the cr

Boris Zbarsky <bzbarsky@mit.edu> has cancelled Simon Fraser <sfraser_bugs@smfr.org>'s request for superreview: Bug 312062: Crash closing a window with a plugin [@ nsObjectFrame::NotifyContentObjectWrapper] https://bugzilla.mozilla.org/show_bug.cgi?id=312062 Attachment 209181: Attachment 206646 from bug 136927 modified to avoid the crash https://bugzilla.mozilla.org/attachment.cgi?id=209181&action=edit

1/21/2006 7:11:08 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 323810] Move forcing into tabs and current windows out of Gecko : [Attachment 209183] Same as previous as diff -w for ease of review

Boris Zbarsky <bzbarsky@mit.edu> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 323810: Move forcing into tabs and current windows out of Gecko https://bugzilla.mozilla.org/show_bug.cgi?id=323810 Attachment 209183: Same as previous as diff -w for ease of review https://bugzilla.mozilla.org/attachment.cgi?id=209183&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> I've tested this and all that. Should probably be banged on some more, though. Again, I'd love feedback on these interface comments and the new nsIWindowProvider interface

1/21/2006 7:06:19 AM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 323810] Move forcing into tabs and current windows out of Gecko : [Attachment 208830] Proposed patch

Boris Zbarsky <bzbarsky@mit.edu> has cancelled Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 323810: Move forcing into tabs and current windows out of Gecko https://bugzilla.mozilla.org/show_bug.cgi?id=323810 Attachment 208830: Proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=208830&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> I eliminated items 4, 5, and 13 from comment 5. Now the scriptable window methods assume they're called from script, while the non-scriptable ones assume that any script on the stack is complet

1/21/2006 6:57:05 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 312062] Crash closing a window with a plugin [@ nsObjectFrame::NotifyContentObjectWrapper] : [Attachment 209181] Attachment 206646 from bug 136927 modified to avoid the cr

Simon Fraser <sfraser_bugs@smfr.org> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 312062: Crash closing a window with a plugin [@ nsObjectFrame::NotifyContentObjectWrapper] https://bugzilla.mozilla.org/show_bug.cgi?id=312062 Attachment 209181: Attachment 206646 from bug 136927 modified to avoid the crash https://bugzilla.mozilla.org/attachment.cgi?id=209181&action=edit ------- Additional Comments from Simon Fraser <sfraser_bugs@smfr.org> This patch (diff -w) is the same as attachment 206646 with a change to make NotifyContentObjectWrapper() a static method, to

1/21/2006 5:40:54 AM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 324159] The accesskey label is doubled if the label ends (X) : [Attachment 209180] Patch rv1.2 for layout/xul

Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has granted Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com>'s request for superreview: Bug 324159: The accesskey label is doubled if the label ends (X) https://bugzilla.mozilla.org/show_bug.cgi?id=324159 Attachment 209180: Patch rv1.2 for layout/xul https://bugzilla.mozilla.org/attachment.cgi?id=209180&action=edit

1/21/2006 5:01:21 AM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 324159] The accesskey label is doubled if the label ends (X) : [Attachment 209113] Patch rv1.1 for layout/xul

Boris Zbarsky <bzbarsky@mit.edu> has granted Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com>'s request for superreview: Bug 324159: The accesskey label is doubled if the label ends (X) https://bugzilla.mozilla.org/show_bug.cgi?id=324159 Attachment 209113: Patch rv1.1 for layout/xul https://bugzilla.mozilla.org/attachment.cgi?id=209113&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: layout/xul/base/src/nsTextBoxFrame.cpp > nsTextBoxFrame::UpdateAccessTitle() >+ // 3 is accessKeyLabel length. Why? I see no reason that shou

1/21/2006 4:39:55 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 323781] Prints still go to printer even after it is deleted : [Attachment 209154] Provisional patch v0.1

Robert O'Callahan (Novell) <roc@ocallahan.org> has asked Robert O'Callahan (Novell) <roc@ocallahan.org> for superreview: Bug 323781: Prints still go to printer even after it is deleted https://bugzilla.mozilla.org/show_bug.cgi?id=323781 Attachment 209154: Provisional patch v0.1 https://bugzilla.mozilla.org/attachment.cgi?id=209154&action=edit

1/21/2006 4:20:20 AM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 323793] Expose .ping attribute for <a> and <area> elements : [Attachment 209172] v1 patch

Boris Zbarsky <bzbarsky@mit.edu> has granted Darin Fisher <darin@meer.net>'s request for superreview: Bug 323793: Expose .ping attribute for <a> and <area> elements https://bugzilla.mozilla.org/show_bug.cgi?id=323793 Attachment 209172: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=209172&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: dom/public/idl/html/nsIDOMNSHTMLAnchorElement.idl >-[scriptable, uuid(a6cf911c-15b3-11d2-932e-00805f8add32)] >+[scriptable, uuid(a756a043-6222-4d00-a015-b5c167e219c7)] It just occurred to me.... We'r

1/21/2006 4:04:54 AM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 324103] DB reference leaks in softoken prevent cert DB from being flushed at close : [Attachment 209074] Proposed fix

Julien Pierre <julien.pierre.bugs@sun.com> has granted Nelson Bolyard <nelson@bolyard.com>'s request for superreview: Bug 324103: DB reference leaks in softoken prevent cert DB from being flushed at close https://bugzilla.mozilla.org/show_bug.cgi?id=324103 Attachment 209074: Proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=209074&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> Looks fine. zero'ing trust->handle after the call to sftk_freeCertDB would be a nice extra.

1/21/2006 3:36:52 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324161] Optimize parseInt for Number : [Attachment 209177] possible fix

Brendan Eich <brendan@mozilla.org> has asked Mike Shaver <shaver@mozilla.org> for superreview: Bug 324161: Optimize parseInt for Number https://bugzilla.mozilla.org/show_bug.cgi?id=324161 Attachment 209177: possible fix https://bugzilla.mozilla.org/attachment.cgi?id=209177&action=edit ------- Additional Comments from Brendan Eich <brendan@mozilla.org> Should we burn some code space to make this case fast? Is it really common? How about JSVAL_IS_DOUBLE cases? /be

1/21/2006 2:59:28 AM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 323351] auto save should time out much sooner : [Attachment 209143] proposed fix

Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 323351: auto save should time out much sooner https://bugzilla.mozilla.org/show_bug.cgi?id=323351 Attachment 209143: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=209143&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> woot

1/21/2006 2:57:53 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324103] DB reference leaks in softoken prevent cert DB from being flushed at close : [Attachment 209074] Proposed fix (?)

Nelson Bolyard <nelson@bolyard.com> has asked Julien Pierre <julien.pierre.bugs@sun.com> for superreview: Bug 324103: DB reference leaks in softoken prevent cert DB from being flushed at close https://bugzilla.mozilla.org/show_bug.cgi?id=324103 Attachment 209074: Proposed fix (?) https://bugzilla.mozilla.org/attachment.cgi?id=209074&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> Julien, please SR for checkin on the 3.11 branch.

1/21/2006 2:22:20 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 323793] Expose .ping attribute for <a> and <area> elements : [Attachment 209172] v1 patch

Darin Fisher <darin@meer.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 323793: Expose .ping attribute for <a> and <area> elements https://bugzilla.mozilla.org/show_bug.cgi?id=323793 Attachment 209172: v1 patch https://bugzilla.mozilla.org/attachment.cgi?id=209172&action=edit

1/21/2006 2:06:37 AM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 324194] Remove the search bar, make quick search and mail views customizeable toolbar buttons : [Attachment 209169] the fix

David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 324194: Remove the search bar, make quick search and mail views customizeable toolbar buttons https://bugzilla.mozilla.org/show_bug.cgi?id=324194 Attachment 209169: the fix https://bugzilla.mozilla.org/attachment.cgi?id=209169&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> nice

1/21/2006 1:46:03 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile

Daniel Veditz <dveditz@cruzio.com> has asked Benjamin Smedberg [:bs] (bsmedberg@) <benjamin@smedbergs.us> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit ------- Additional Comments from Daniel Veditz <dveditz@cruzio.com> blame says bsmedberg so delegating sr= request to him, change r= to josh for mac platform consist

1/21/2006 1:40:46 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324194] Remove the search bar, make quick search and mail views customizeable toolbar buttons : [Attachment 209169] the fix

Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 324194: Remove the search bar, make quick search and mail views customizeable toolbar buttons https://bugzilla.mozilla.org/show_bug.cgi?id=324194 Attachment 209169: the fix https://bugzilla.mozilla.org/attachment.cgi?id=209169&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> This implements the UI changes I listed above for 3-pane, address book, Still need to work on the CSS for the Mac and some more polish adjustments for windows. May als

1/21/2006 1:15:52 AM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 303018] SVG conditional processing is only implemented for <switch> : [Attachment 208763] Updated patch with tests combined

Scooter Morris <scootermorris@comcast.net> has cancelled Scooter Morris <scootermorris@comcast.net>'s request for superreview: Bug 303018: SVG conditional processing is only implemented for <switch> https://bugzilla.mozilla.org/show_bug.cgi?id=303018 Attachment 208763: Updated patch with tests combined https://bugzilla.mozilla.org/attachment.cgi?id=208763&action=edit

1/21/2006 1:05:39 AM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 324182] Userdefined tags can lose one of their attributes : [Attachment 209155] Cleanup

Johnny Stenback <jst@mozilla.org> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 324182: Userdefined tags can lose one of their attributes https://bugzilla.mozilla.org/show_bug.cgi?id=324182 Attachment 209155: Cleanup https://bugzilla.mozilla.org/attachment.cgi?id=209155&action=edit ------- Additional Comments from Johnny Stenback <jst@mozilla.org> sr=jst

1/21/2006 12:14:46 AM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 315633] "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" : [Attachment 206616] Use Mac-appropriate text in profile

Steuard Jensen <steuard+mozilla@slimy.com> has asked Daniel Veditz <dveditz@cruzio.com> for superreview: Bug 315633: "Create Profile" dialog text doesn't match button text: "Click Finish"->"Done", "click Next"->"Continue" https://bugzilla.mozilla.org/show_bug.cgi?id=315633 Attachment 206616: Use Mac-appropriate text in profile creation https://bugzilla.mozilla.org/attachment.cgi?id=206616&action=edit

1/21/2006 12:02:28 AM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 322628] Palm Sync Build Changes : [Attachment 209150] changes to call the uninstaller and to stop shipping CondMgr and HSAPI

David Bienvenu <bienvenu@nventure.com> has granted Scott MacGregor <mscott@mozilla.org>'s request for superreview: Bug 322628: Palm Sync Build Changes https://bugzilla.mozilla.org/show_bug.cgi?id=322628 Attachment 209150: changes to call the uninstaller and to stop shipping CondMgr and HSAPI https://bugzilla.mozilla.org/attachment.cgi?id=209150&action=edit

1/20/2006 11:46:43 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324182] Userdefined tags can lose one of their attributes : [Attachment 209155] Cleanup

Blake Kaplan <mrbkap@gmail.com> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 324182: Userdefined tags can lose one of their attributes https://bugzilla.mozilla.org/show_bug.cgi?id=324182 Attachment 209155: Cleanup https://bugzilla.mozilla.org/attachment.cgi?id=209155&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> This consolidates a duplicated block and (I think) fixes this bug independently of the previous patch. It also turns an if (...) if (...) into an if (...) else if (...) to avoid potential problems if the element table was

1/20/2006 11:32:39 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 324182] Userdefined tags can lose one of their attributes : [Attachment 209146] Fix

Boris Zbarsky <bzbarsky@mit.edu> has granted Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 324182: Userdefined tags can lose one of their attributes https://bugzilla.mozilla.org/show_bug.cgi?id=324182 Attachment 209146: Fix https://bugzilla.mozilla.org/attachment.cgi?id=209146&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> sr=bzbarsky; sicking's right.

1/20/2006 11:12:04 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 322628] Palm Sync Build Changes : [Attachment 209150] changes to call the uninstaller and to stop shipping CondMgr and HSAPI

Scott MacGregor <mscott@mozilla.org> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 322628: Palm Sync Build Changes https://bugzilla.mozilla.org/show_bug.cgi?id=322628 Attachment 209150: changes to call the uninstaller and to stop shipping CondMgr and HSAPI https://bugzilla.mozilla.org/attachment.cgi?id=209150&action=edit ------- Additional Comments from Scott MacGregor <mscott@mozilla.org> Some of these changes are things you've already seen. 1) Call PalmSyncInstall.exe /us (silent uninstall) when we receive the uninstall notifcation from the extension m

1/20/2006 10:44:39 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 323131] crash after saving all attachments [@ nsMessenger::SaveAllAttachments] : [Attachment 208609] the actual fix.

Scott MacGregor <mscott@mozilla.org> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 323131: crash after saving all attachments [@ nsMessenger::SaveAllAttachments] https://bugzilla.mozilla.org/show_bug.cgi?id=323131 Attachment 208609: the actual fix. https://bugzilla.mozilla.org/attachment.cgi?id=208609&action=edit

1/20/2006 10:33:34 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 317566] Using global LDAP server prefs for autocomplete lookup does not always work correctly : [Attachment 208307] Patch v5

David Bienvenu <bienvenu@nventure.com> has granted Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 317566: Using global LDAP server prefs for autocomplete lookup does not always work correctly https://bugzilla.mozilla.org/show_bug.cgi?id=317566 Attachment 208307: Patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=208307&action=edit

1/20/2006 10:30:26 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324182] Userdefined tags can lose one of their attributes : [Attachment 209146] Fix

Blake Kaplan <mrbkap@gmail.com> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 324182: Userdefined tags can lose one of their attributes https://bugzilla.mozilla.org/show_bug.cgi?id=324182 Attachment 209146: Fix https://bugzilla.mozilla.org/attachment.cgi?id=209146&action=edit

1/20/2006 10:23:31 PM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 324182] Userdefined tags can lose one of their attributes : [Attachment 209145] Fix

Blake Kaplan <mrbkap@gmail.com> has cancelled Blake Kaplan <mrbkap@gmail.com>'s request for superreview: Bug 324182: Userdefined tags can lose one of their attributes https://bugzilla.mozilla.org/show_bug.cgi?id=324182 Attachment 209145: Fix https://bugzilla.mozilla.org/attachment.cgi?id=209145&action=edit ------- Additional Comments from Blake Kaplan <mrbkap@gmail.com> This is the wrong patch (even for the cleanup) :(

1/20/2006 10:23:00 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324182] Userdefined tags can lose one of their attributes : [Attachment 209145] Fix

Blake Kaplan <mrbkap@gmail.com> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 324182: Userdefined tags can lose one of their attributes https://bugzilla.mozilla.org/show_bug.cgi?id=324182 Attachment 209145: Fix https://bugzilla.mozilla.org/attachment.cgi?id=209145&action=edit

1/20/2006 10:22:26 PM 0 bugzilla-request-dae...@mozilla.org
superreview denied: [Bug 323211] convert mailnews/import to nsIFile : [Attachment 208572] Part 1 (-w)

Dan Mosedale <dmose@mozilla.org> has denied Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 323211: convert mailnews/import to nsIFile https://bugzilla.mozilla.org/show_bug.cgi?id=323211 Attachment 208572: Part 1 (-w) https://bugzilla.mozilla.org/attachment.cgi?id=208572&action=edit ------- Additional Comments from Dan Mosedale <dmose@mozilla.org> There seems to be a prevailing bracing style of inner blocks in these files that look like if (foo) { bar } This patch leaves the files with a mix of that style and if (foo) { bar } Matchin

1/20/2006 10:22:12 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 323351] auto save should time out much sooner : [Attachment 209143] proposed fix

David Bienvenu <bienvenu@nventure.com> has asked Scott MacGregor <mscott@mozilla.org> for superreview: Bug 323351: auto save should time out much sooner https://bugzilla.mozilla.org/show_bug.cgi?id=323351 Attachment 209143: proposed fix https://bugzilla.mozilla.org/attachment.cgi?id=209143&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> with this patch, we don't disable the ui at all during auto save. This should really cut down on the ui glitches. I've also reworked the message changed flag handling because now the user can dirty the message bo

1/20/2006 10:05:45 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 312391] Accept languages empties when IE profile migration is selected. : [Attachment 203588] Quick patch

Mike Connor <mconnor@mozilla.com> has granted Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com>'s request for superreview: Bug 312391: Accept languages empties when IE profile migration is selected. https://bugzilla.mozilla.org/show_bug.cgi?id=312391 Attachment 203588: Quick patch https://bugzilla.mozilla.org/attachment.cgi?id=203588&action=edit

1/20/2006 9:41:29 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 316629] SSLSocketException failures : [Attachment 208905] Increased the SSLServerSocket timeout to 90 sec

glen beasley <glen.beasley@sun.com> has granted Sandeep Konchady <Sandeep.Konchady@Sun.COM>'s request for superreview: Bug 316629: SSLSocketException failures https://bugzilla.mozilla.org/show_bug.cgi?id=316629 Attachment 208905: Increased the SSLServerSocket timeout to 90 sec https://bugzilla.mozilla.org/attachment.cgi?id=208905&action=edit

1/20/2006 8:47:45 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 323964] DPI preference has different meaning on OS/2 than other platforms : [Attachment 208928] patch

Robert O'Callahan (Novell) <roc@ocallahan.org> has granted David Baron <dbaron@mozilla.com>'s request for superreview: Bug 323964: DPI preference has different meaning on OS/2 than other platforms https://bugzilla.mozilla.org/show_bug.cgi?id=323964 Attachment 208928: patch https://bugzilla.mozilla.org/attachment.cgi?id=208928&action=edit

1/20/2006 7:23:03 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 233082] default value of browser.display.screen_resolution is wrong : [Attachment 208927] patch

Robert O'Callahan (Novell) <roc@ocallahan.org> has granted David Baron <dbaron@mozilla.com>'s request for superreview: Bug 233082: default value of browser.display.screen_resolution is wrong https://bugzilla.mozilla.org/show_bug.cgi?id=233082 Attachment 208927: patch https://bugzilla.mozilla.org/attachment.cgi?id=208927&action=edit

1/20/2006 7:22:08 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 323742] "ASSERTION: no page breaks yet" with this MathML testcase : [Attachment 208838] patch

Robert O'Callahan (Novell) <roc@ocallahan.org> has granted rbs@maths.uq.edu.au's request for superreview: Bug 323742: "ASSERTION: no page breaks yet" with this MathML testcase https://bugzilla.mozilla.org/show_bug.cgi?id=323742 Attachment 208838: patch https://bugzilla.mozilla.org/attachment.cgi?id=208838&action=edit

1/20/2006 7:21:01 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 323741] "ASSERTION: index out of range" with this MathML testcase : [Attachment 208832] patch

Robert O'Callahan (Novell) <roc@ocallahan.org> has granted rbs@maths.uq.edu.au's request for superreview: Bug 323741: "ASSERTION: index out of range" with this MathML testcase https://bugzilla.mozilla.org/show_bug.cgi?id=323741 Attachment 208832: patch https://bugzilla.mozilla.org/attachment.cgi?id=208832&action=edit

1/20/2006 7:19:36 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 323738] ASSERTION: invalid call to GetPreferredStretchSize : [Attachment 208783] patch

Robert O'Callahan (Novell) <roc@ocallahan.org> has granted rbs@maths.uq.edu.au's request for superreview: Bug 323738: ASSERTION: invalid call to GetPreferredStretchSize https://bugzilla.mozilla.org/show_bug.cgi?id=323738 Attachment 208783: patch https://bugzilla.mozilla.org/attachment.cgi?id=208783&action=edit

1/20/2006 7:18:39 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 322947] Page scrolls up when clicking the middle mouse button in frame : [Attachment 208214] Patch v1

Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Ere Maijala <emaijala@kolumbus.fi>'s request for superreview: Bug 322947: Page scrolls up when clicking the middle mouse button in frame https://bugzilla.mozilla.org/show_bug.cgi?id=322947 Attachment 208214: Patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=208214&action=edit

1/20/2006 7:14:16 PM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 296159] npruntime API does not support enumeration : [Attachment 208365] Patch v5

Alfred Peng <alfred.peng@sun.com> has cancelled Alfred Peng <alfred.peng@sun.com>'s request for superreview: Bug 296159: npruntime API does not support enumeration https://bugzilla.mozilla.org/show_bug.cgi?id=296159 Attachment 208365: Patch v5 https://bugzilla.mozilla.org/attachment.cgi?id=208365&action=edit ------- Additional Comments from Alfred Peng <alfred.peng@sun.com> New patch based on Blake's review.

1/20/2006 7:08:54 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 296159] npruntime API does not support enumeration : [Attachment 209126] Patch v6

Alfred Peng <alfred.peng@sun.com> has asked Johnny Stenback <jst@mozilla.org> for superreview: Bug 296159: npruntime API does not support enumeration https://bugzilla.mozilla.org/show_bug.cgi?id=296159 Attachment 209126: Patch v6 https://bugzilla.mozilla.org/attachment.cgi?id=209126&action=edit ------- Additional Comments from Alfred Peng <alfred.peng@sun.com> New patch based on Blake's review.

1/20/2006 7:08:54 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 307367] [BC] print preview doesn't match print for thin borders on windows : [Attachment 207175] patch

Robert O'Callahan (Novell) <roc@ocallahan.org> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 307367: [BC] print preview doesn't match print for thin borders on windows https://bugzilla.mozilla.org/show_bug.cgi?id=307367 Attachment 207175: patch https://bugzilla.mozilla.org/attachment.cgi?id=207175&action=edit

1/20/2006 6:59:03 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 324124] nsCOMPtr can be constructed with const char* and nsID : [Attachment 209088] Make nsGetServiceBy{CID,ContractID}'s constructors explicit

David Baron <dbaron@mozilla.com> has granted jag (Peter Annema) <jag@tty.nl>'s request for superreview: Bug 324124: nsCOMPtr can be constructed with const char* and nsID https://bugzilla.mozilla.org/show_bug.cgi?id=324124 Attachment 209088: Make nsGetServiceBy{CID,ContractID}'s constructors explicit https://bugzilla.mozilla.org/attachment.cgi?id=209088&action=edit

1/20/2006 5:46:00 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 321161] crash occurs if no RSA key is present [@ ssl2_BeginServerHandshake] : [Attachment 208961] proposed patch

Nelson Bolyard <nelson@bolyard.com> has asked Julien Pierre <julien.pierre.bugs@sun.com> for superreview: Bug 321161: crash occurs if no RSA key is present [@ ssl2_BeginServerHandshake] https://bugzilla.mozilla.org/show_bug.cgi?id=321161 Attachment 208961: proposed patch https://bugzilla.mozilla.org/attachment.cgi?id=208961&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> Checked in on trunk. Seeking SR for checkin on 3.11 branch. Checking in ssl/sslcon.c; new revision: 1.29; previous revision: 1.28

1/20/2006 5:42:44 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324159] The accesskey label is doubled if the label ends (X) : [Attachment 209116] Patch rv1.0 for xpfe/global/resources/content/bindings

Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> for superreview: Bug 324159: The accesskey label is doubled if the label ends (X) https://bugzilla.mozilla.org/show_bug.cgi?id=324159 Attachment 209116: Patch rv1.0 for xpfe/global/resources/content/bindings https://bugzilla.mozilla.org/attachment.cgi?id=209116&action=edit

1/20/2006 5:30:57 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324159] The accesskey label is doubled if the label ends (X) : [Attachment 209116] Patch rv1.0 for xpfe/global/resources/content/bindings

Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked for superreview: Bug 324159: The accesskey label is doubled if the label ends (X) https://bugzilla.mozilla.org/show_bug.cgi?id=324159 Attachment 209116: Patch rv1.0 for xpfe/global/resources/content/bindings https://bugzilla.mozilla.org/attachment.cgi?id=209116&action=edit

1/20/2006 5:29:53 PM 0 bugzilla-request-dae...@mozilla.org
superreview cancelled: [Bug 324159] The accesskey label is doubled if the label ends (X) : [Attachment 209112] Patch rv1.0 for layout/xul

Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has cancelled Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com>'s request for superreview: Bug 324159: The accesskey label is doubled if the label ends (X) https://bugzilla.mozilla.org/show_bug.cgi?id=324159 Attachment 209112: Patch rv1.0 for layout/xul https://bugzilla.mozilla.org/attachment.cgi?id=209112&action=edit

1/20/2006 5:20:22 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324159] The accesskey label is doubled if the label ends (X) : [Attachment 209113] Patch rv1.1 for layout/xul

Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 324159: The accesskey label is doubled if the label ends (X) https://bugzilla.mozilla.org/show_bug.cgi?id=324159 Attachment 209113: Patch rv1.1 for layout/xul https://bugzilla.mozilla.org/attachment.cgi?id=209113&action=edit

1/20/2006 5:20:22 PM 0 bugzilla-request-dae...@mozilla.org
superreview requested: [Bug 324159] The accesskey label is doubled if the label ends (X) : [Attachment 209112] Patch rv1.0 for layout/xul

Masayuki Nakano (Mozilla Japan)(busy) <masayuki@d-toybox.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 324159: The accesskey label is doubled if the label ends (X) https://bugzilla.mozilla.org/show_bug.cgi?id=324159 Attachment 209112: Patch rv1.0 for layout/xul https://bugzilla.mozilla.org/attachment.cgi?id=209112&action=edit

1/20/2006 5:18:33 PM 0 bugzilla-request-dae...@mozilla.org
superreview granted: [Bug 324109] Re-Add ocsp info string in cert manager, that was accidentially removed : [Attachment 209076] Patch v1

Robert Relyea <rrelyea@redhat.com> has granted Kai Engert (kaie) <kengert@redhat.com>'s request for superreview: Bug 324109: Re-Add ocsp info string in cert manager, that was accidentially removed https://bugzilla.mozilla.org/show_bug.cgi?id=324109 Attachment 209076: Patch v1 https://bugzilla.mozilla.org/attachment.cgi?id=209076&action=edit ------- Additional Comments from Robert Relyea <rrelyea@redhat.com> r=rrelyea

1/20/2006 4:30:15 PM 0 bugzilla-request-dae...@mozilla.org
superreview denied: [Bug 321490] Make SeaMonkey compatible again with moveTabTo implementation of the Firefox : [Attachment 209046] Use mTabs.item() and get tab from insertBefore

neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> has denied jag (Peter Annema) <jag@tty.nl>'s request for superreview: Bug 321490: Make SeaMonkey compatible again with moveTabTo implementation of the Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=321490 Attachment 209046: Use mTabs.item() and get tab from insertBefore https://bugzilla.mozilla.org/attachment.cgi?id=209046&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@bluebottle.com> >+ if (aDestIndex > aSrcIndex) Hmm, I should have reviewed these in order... needs to

1/20/2006 2:13:02 PM 0 bugzilla-request-dae...@mozilla.org

Pages: 2 3











Newest Articles

[Hendrix] In private browsing
2 hour 23 mins ago

popup blocker exceptions with autoconfig
2 hour 41 mins ago

[Hendrix] update auf version 3.5.8
3 hour 6 mins ago

New Firefox UX Team update: Expanded roadmap, projects & Work Week outcomes
3 hour 11 mins ago

[Hendrix] plavix and ed zvx
3 hour 20 mins ago